Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various www-frontend parity fixes #598

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Conversation

stephiescastle
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

  • removes BlockTwitterEmbed
  • fixes the /home/ prefix in BaseButton and ensures all links are using either BaseButton or BaseLink (follow-up to fix: removing /home/ prefix from BaseLink #596)
  • fixes passing query params in NavSearchForm
  • fixes hydration error in SwimlaneCTA

Instructions to test

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added the feature parity Work needed to maintain consistency between our implementations of Explorer 1 label Sep 5, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 5, 2024
@stephiescastle stephiescastle merged commit 563964d into main Sep 5, 2024
6 checks passed
@stephiescastle stephiescastle deleted the fix/various-parity-fixes branch September 5, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature parity Work needed to maintain consistency between our implementations of Explorer 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants